Swap rejection and reflectron voltages in lookup table#2872
Merged
lacoak21 merged 4 commits intoIMAP-Science-Operations-Center:devfrom Apr 1, 2026
Merged
Conversation
Contributor
|
For updating the test file you will need to go to this file imap_processing/tests/external_test_data_config.py Also update it here imap_processing/tests/idex/conftest.py - variable "L1B_EXAMPLE_FILE" |
lacoak21
reviewed
Apr 1, 2026
lacoak21
reviewed
Apr 1, 2026
lacoak21
reviewed
Apr 1, 2026
lacoak21
reviewed
Apr 1, 2026
lacoak21
approved these changes
Apr 1, 2026
Contributor
|
Looks great! Im going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Swapped the rejection and reflectron voltages in the lookup table for the L1B instrument settings conversion.
File changes
idex_variable_unpacking_and_eu_conversion.csv had two rows swapped in the mnemonic column. These variables were swapped from the SUDA to IDEX flight software and not properly documented.
Testing
No new unit tests added, only the existing ones.