Add error throw for MAG if no data is in the file#3097
Draft
maxinelasp wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
Draft
Add error throw for MAG if no data is in the file#3097maxinelasp wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
maxinelasp wants to merge 14 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
…1. Updated all documentation to remove references to Poetry 1 and include more information for Poetry 2. Co-authored with Claude.
…MAP-Science-Operations-Center#3094) * idex updated l1b logic * fix idex test
…Center#3078) * mod nso_esa_step * update comment
…ons-Center#3082) * tests and code to correct rectangular map * comment update * pr comments * pr comments * type annotation
…ions-Center#2949) * Updated dead time vars, constants and attr file. * Removed print * idex event dead time test * Added test_get_event_dead_time() --------- Co-authored-by: Luisa <luisa.coakley@lasp.colorado.edu>
…Center#3077) * mod nso_esa_step * fix version one half_spin_mask * update comment * pr comments
…MAP-Science-Operations-Center#3107) float64 cannot represent int64 TT2000 epochs near 8e17 ns exactly, so adding a float time_shift_ns silently quantized the epoch values. Round to integer nanoseconds in shift_time and timeshift_vectors_per_second so the arithmetic stays on the int64 grid.
…perations-Center#3104) * Add SDS data manager documentation to imap_processing Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> and Claude
…enter#3095) * Add epoch_delta_minus to L2 maps variables * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove duplicate check * PR feedback --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…#3084) * Upgrade from poetry 1.7 to poetry 2.3, including conforming to PEP 621. Updated all documentation to remove references to Poetry 1 and include more information for Poetry 2. Co-authored with Claude. * Add python version placeholder file for documentation generation * Updating docs, fixing python version * Downgrading packages to avoid test failures * Adding documentation on upgrading poetry
maxinelasp
force-pushed
the
mag-2830-applying-cal-dim-zero
branch
from
9ff287c to
b51b46e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This addresses #2830 and part of #3060 by adding a more intelligent error message around truncating MAG data to 24 hours.
Overview
In the case where truncation leaves no data, throw an error saying this instead of letting later processes fail in a more obscure way.
This fixes both L1D and L2 for this issue.
Dependent on #3084 so leaving as a draft until that PR is merged.