Stripe's fast_automatic_capture_beta API changes#74
Draft
LeafHacker wants to merge 1 commit intomasterfrom
Draft
Stripe's fast_automatic_capture_beta API changes#74LeafHacker wants to merge 1 commit intomasterfrom
LeafHacker wants to merge 1 commit intomasterfrom
Conversation
Stripe are asking for feedback on their fast_automatic_capture_beta. This commit attempts to update our code to support the new API.
LeafHacker
commented
Apr 16, 2021
| return c.String(http.StatusUnprocessableEntity, "Cannot handle a charge that has been refunded") | ||
| } | ||
| if charge.TransferGroup != "" { | ||
| return c.String(http.StatusUnprocessableEntity, "Cannot handle a charge that has already been distributed") |
Contributor
Author
There was a problem hiding this comment.
Is this reliable? This check assumes that calling transfer.New() with SourceTransaction set to the charge's ID will update the charge's transfer group.
This is intended as a way to check if our DistributeDonation func has already been run against this charge, since we don't want to run it twice for a given charge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stripe are asking for feedback on their fast_automatic_capture_beta. This commit attempts to update our code to support the new API.
This PR is untested.