Skip to content

feat(labels): add the area:benchmark and area:apps labels - #532

Open
Dong1017 wants to merge 2 commits into
mainfrom
label/area-benchmark
Open

Dong1017 wants to merge 2 commits into
mainfrom
label/area-benchmark

Conversation

@Dong1017

@Dong1017 Dong1017 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Governing Issue and delivery slice

  • Governing Issue: none. This is a label-manifest change requested on its own; task: Benchmark production prepare and frozen resource closure #430 and feat(benchmark): add frozen P1 preparation port #530 are the benchmark work the new labels name, not its acceptance owner, and they are not relabeled here.

  • Accepted scope / delegation: add two official labels to the checked-in manifest, area:benchmark and area:apps. The repository labels are created from the manifest after this PR merges, per the Labels section of docs/agent-collaboration.md.

  • What this PR delivers: two entries in .github/labels.json, grouped with the other area:* entries, each with exactly the fields name, group and description:

    • area:benchmark — Benchmark line: preparation ports, metric contracts, validators, and isolated workers (85 characters).
    • area:apps — Apps line: CLI, Python entrypoints, host inspection, workflows, views, and adapters (83 characters).

    Both are within the 100-character limit tools/check_labels.py enforces.

  • What it does not deliver: no repository label is created, renamed or deleted by this PR, and no Issue or PR is relabeled, including feat(benchmark): add frozen P1 preparation port #530 and task: Benchmark production prepare and frozen resource closure #430. Nothing changes in .github/workflows/ci-nightly.yml, tools/check_labels.py or tests/test_check_labels.py.

The repository's stray high priority label is out of scope here and stays untouched: it is not in labels.json and not added to it.

Knowledge authorship declaration

Not applicable. .github/labels.json is outside protected_paths and policy_paths in .github/knowledge-model-policy.json. The block below is disclosure only.

{
  "schema_version": 1,
  "head_sha": "829945bf0cf734d8258eb569f30dd56d17cddb8b",
  "human_only": false,
  "material_ai_authors": [
    {
      "tool": "Claude Code",
      "model_id": "deepseek-v4.1-flash-1017",
      "effort": "unknown",
      "role": "author"
    }
  ]
}

Changed artifacts and evidence

Requirement Actual change Check / evidence and result Remaining gap
The manifest accepts both new entries .github/labels.json: area:benchmark after area:harness, area:apps after area:benchmark pytest tests/test_check_labels.py: 40 passed. manifest_problems returns no problem; the JSON parses; the 23 names are unique none
Descriptions match the agreed text Both objects carry the exact requested strings; lengths 85 and 83 Printed per-entry lengths from the parsed file none
No referenced label breaks No template or tools/skill_eval_*_config.json names either new label; area:* stays a group reference in the guide tools/check_labels.py against the live label list reports only area:benchmark: in labels.json, missing from the repository The nightly safety-net job cannot be green until the repository labels exist; that step follows the merge
The change is confined to the manifest git diff --stat d9cacdb0: 1 file, 5 insertions git diff --check clean none

Checks and dependencies

  • Checks actually run (result and tested scope): python -m pytest tests/test_check_labels.py -q (40 passed) locally; JSON parse of .github/labels.json with the 23 names, per-entry description lengths and a uniqueness assertion; tools/check_labels.py against a live label listing; git diff --check.
  • Failed, skipped, timed-out or not-run checks (if applicable): the full suite and ruff were not run locally; CI covers them.
  • Dependencies / shared interfaces / integration assumptions: the drift check compares names and descriptions only, so the documented order — manifest first, repository label second — holds. Every area:* label is applied by the creator at creation, so existing Issues are unaffected by the omission.
  • Review state: the first commit d9cacdb0 carried one approval. Commit 829945bf replaces it and the repository dismisses approvals on push, so both approvals must be re-earned at the new head.

Remaining work and Issue closure

The benchmark line (preparation ports, metric contracts, validators and
isolated workers) has no area label, so its Issues cannot state an area
at creation. Add it next to the other area:* entries with the agreed
description.

This changes the checked-in manifest only. It does not create, rename or
delete a repository label and does not relabel any Issue or PR; the
repository label follows after this manifest merges.

Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author)
Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
@Dong1017 Dong1017 added the kind:task Bounded delivery task with a delegated slice label Nov 20, 2026
zengchuang-hw
zengchuang-hw previously approved these changes Nov 20, 2026

@zengchuang-hw zengchuang-hw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

初次独立检视 1b826b5f → d9cacdb0:仅 .github/labels.json 增加一个不重复的 area:benchmark,分组、字段、命名及 85 字符描述均符合现有校验器。按仓库约定,此 PR 只登记清单;不会自动创建 GitHub label、修改任何对象标签或授予授权。批准前无必修项。

已静态核对完整差异、清单、校验器与 Labels 约定;未运行脚本或查询 CI。

@Dong1017 Dong1017 added area:process Repo-wide process, governance, privacy and security rules and removed kind:task Bounded delivery task with a delegated slice labels Nov 20, 2026
The benchmark line (preparation ports, metric contracts, validators and
isolated workers) and the apps line (CLI, Python entrypoints, host
inspection, workflows, views and adapters) have no area label, so their
Issues cannot state an area at creation. Add both next to the other
area:* entries with the agreed descriptions.

This changes the checked-in manifest only. It does not create, rename or
delete a repository label and does not relabel any Issue or PR; the two
repository labels follow after this manifest merges.

Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author)
Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
@Dong1017 Dong1017 changed the title feat(labels): add the area:benchmark label feat(labels): add the area:benchmark and area:apps labels Nov 20, 2026
@Dong1017
Dong1017 enabled auto-merge (squash) November 20, 2026 03:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR review verdict — PASS
Reviewed base 1b826b5f9666a8b734000e1eb2990e582cdef876 and head 829945bf0cf734d8258eb569f30dd56d17cddb8b.

Independent third-party technical verify (cursor[bot]; collaborator permission none — not a write+ eligible Approver; does not complete dual tip / merge-ready).

Verified tip diff is only .github/labels.json: adds unique area:benchmark and area:apps under group area, with descriptions within the 1–100 character validator bound (tools/check_labels.py). Manifest uniqueness holds (23 entries). Matches Labels convention: PR registers the manifest only; does not create live GitHub labels.

Ready tip green (full-check 3.10/3.11 + declarations + installed-package + dashboard-browser + pr-references). Prior zengchuang-hw Approve on d9cacdb0… was dismissed by tip move; this is cursor first formal tip vote (author Dong1017 → Dong ineligible).

Merge still needs write+ independent Approves / steward integration — not claimed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:process Repo-wide process, governance, privacy and security rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants