Add Legend watch face#2450
Conversation
|
Build size and comparison to main:
|
mark9064
left a comment
There was a problem hiding this comment.
Looks great overall :)
A few comments, but nothing big
I am curioous, how much did you use LLMs (if at all) during development of this watchface?
88014ff to
db9d562
Compare
|
@mark9064 Thanks for the fast review! I have fixed the issues you highlighted and rebased the PR. Can you please review again? |
There was a problem hiding this comment.
I think the code itself is all good. Could you take a look at all the comments though, some of them seem a bit overblown - I would say that most of the description isn't needed because if I want detail I will read the code. Visual markers for sections are probably still useful though. I've highlighted a few here
I find LLMs quite like to do this with comments :)
Also, have you tested this with AOD? Does it still look OK? (It's fine if some UI elements disappear that aren't important, but it needs to stay usable)
|
@mark9064 Thanks! |
|
@mark9064 If any other adjustments are needed, please let me know! |
|
I think there are still a couple verbose comments, I don't think any of them need to be longer than a line. The rewords you have done so far are nice improvements :) Looks great! |
An elegant and very practical digital watch face. Uses only fonts already in InfiniTime and no external resources. Has the standard functionality: * shows time, date (without year) and day of week * supports 24 and 12 hour time formats * BLE, new notification and alarm clock icons * battery percentage (green when charging) * steps and heart rate * temperature and weather icon Additionally: * visual indication (amber dot) for any notification(s) * visual indication (red or blue line) when notifications are muted * battery percentage turns red when 20% or less * stopwatch and timer icons (when active) * colorful sun, snow and thunderstorm weather icons * generally uses brighter colors for more urgent things
|
@mark9064 Thanks for the feedback! Can you please review? |



An elegant and very practical digital watch face.
Uses only fonts already in InfiniTime and no external resources. Has the standard functionality:
Additionally: