Skip to content

BUG: Remove hardcoded HDF5 system paths from ITKTargets #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 2 commits into from
Jun 24, 2026
Merged

BUG: Remove hardcoded HDF5 system paths from ITKTargets #6494

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32681ad
BUG: Remove hardcoded HDF5 system include paths from ITKTargets
blowekamp Jun 22, 2026
23c9f04
BUG: Require HDF5 imported targets; error if none found
blowekamp Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 34 additions & 75 deletions Modules/ThirdParty/HDF5/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,88 +34,47 @@ endif()
)

if(BUILD_SHARED_LIBS)
if(TARGET hdf5-shared)
set(
ITKHDF5_LIBRARIES
hdf5_cpp-shared
hdf5-shared
hdf5_hl-shared
hdf5_hl_cpp-shared
)
elseif(TARGET hdf5::hdf5-shared)
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp-shared
hdf5::hdf5-shared
hdf5::hdf5_hl-shared
hdf5::hdf5_hl_cpp-shared
)
elseif(TARGET hdf5::hdf5)
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp
hdf5::hdf5
hdf5::hdf5_hl
hdf5::hdf5_hl_cpp
)
else()
set(
ITKHDF5_LIBRARIES
${HDF5_C_SHARED_LIBRARY}
${HDF5_CXX_SHARED_LIBRARY}
${HDF5_CXX_LIBRARY_NAMES}
${HDF5_HL_SHARED_LIBRARY}
${HDF5_LIBRARIES}
)
endif()
set(_hdf5_type -shared)
else()
if(TARGET hdf5-static)
set(
ITKHDF5_LIBRARIES
hdf5_cpp-static
hdf5-static
hdf5_hl-static
hdf5_hl_cpp-static
)
elseif(TARGET hdf5::hdf5-static)
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp-static
hdf5::hdf5-static
hdf5::hdf5_hl-static
hdf5::hdf5_hl_cpp-static
)
elseif(TARGET hdf5::hdf5)
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp
hdf5::hdf5
hdf5::hdf5_hl
hdf5::hdf5_hl_cpp
)
else()
set(
ITKHDF5_LIBRARIES
${HDF5_C_STATIC_LIBRARY}
${HDF5_CXX_STATIC_LIBRARY}
${HDF5_CXX_LIBRARY_NAMES}
${HDF5_HL_STATIC_LIBRARY}
${HDF5_LIBRARIES}
)
endif()
set(_hdf5_type -static)
endif()

if(TARGET hdf5::hdf5${_hdf5_type})
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp${_hdf5_type}
hdf5::hdf5${_hdf5_type}
hdf5::hdf5_hl${_hdf5_type}
hdf5::hdf5_hl_cpp${_hdf5_type}
)
elseif(TARGET hdf5${_hdf5_type})
set(
ITKHDF5_LIBRARIES
hdf5_cpp${_hdf5_type}
hdf5${_hdf5_type}
hdf5_hl${_hdf5_type}
hdf5_hl_cpp${_hdf5_type}
)
elseif(TARGET hdf5::hdf5)
set(
ITKHDF5_LIBRARIES
hdf5::hdf5_cpp
hdf5::hdf5
hdf5::hdf5_hl
hdf5::hdf5_hl_cpp
)
else()
message(
FATAL_ERROR
"ITK_USE_SYSTEM_HDF5 is ON but the HDF5 targets were not found. "
"Please set HDF5_DIR to the directory containing HDF5Config.cmake."
)
endif()

set(
ITKHDF5_INCLUDE_DIRS
${ITKHDF5_BINARY_DIR}/src # itk_hdf5.h and itk_H5Cpp.h
)
set(
ITKHDF5_SYSTEM_INCLUDE_DIRS
${HDF5_INCLUDE_DIR}
${HDF5_INCLUDE_DIR_HL}
${HDF5_INCLUDE_DIRS}
${HDF5_INCLUDE_DIR_CPP}
)

set(ITKHDF5_NO_SRC 1)
else()
Expand Down
Loading