Open
Conversation
facebook-github-bot
added
the
CLA Signed
amyreese
force-pushed
the
use_primitive_types_branch
branch
from
c7c145b to
c8b3bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new rule "UseBuiltInsTypes" for PYTHON_VERSION >= 3.10 -- See PEP 585 – Type Hinting Generics In Standard Collections.
This rule is the opposite of the existing rule UseTypesFromTyping.
Test Plan
See added tests in rule.
NOTE
Even when adding PYTHON_VERSION = ">= 3.10" the rule still runs on fixit, even though it's pinned to use python 3.8 (hence the test test_this_project_is_clean fails).
What am I missing?