Conversation
smart_waits.wait_until_screen_stable bakes the settle logic inside a time.sleep loop over live frames, so you can't feed it a recorded series or unit-test the decision. Extract it: given a stream of churn values, report when churn stayed <= max_churn for quiet_samples in a row (a spike resets the run). SettleTracker is the incremental form. Pure-stdlib, no clock, no capture.
…tor-batch Add settle_detector: settle decision as a pure seam over a churn series
Nothing mapped line height to heading levels or built a section outline; ocr/structure and element_parse are positional and text_blocks doesn't rank. Apply the standard heuristic: a line taller than heading_ratio x the median line height is a heading, and distinct heading heights become levels (tallest = 1). classify_lines tags each line; outline returns the headings in order.
…ent-batch Add heading_segment: heading vs body classification + document outline
trajectory_eval scores a whole trajectory with no per-step evidence;
agent_trace emits spans not quality; agent_replay stores steps but doesn't
score. Compose action_effect + observation_delta + postcondition into one
per-step record, then a deterministic rule-based scorer gives
{outcome, process_score, reasons} (no model), and to_judge_prompt renders it for
an optional LLM-as-judge.
…res-batch Add critic_features: per-step critic bundle + rule-based scorer
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 74 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release — settle / outline / critic
Ships 3 net-new features (#389–#391, docs v175–v177) to
main, all merged todevCI-green (SonarCloud + Codacy issues=0 + Actions matrices + Docker headless). Each ships the full 5-layer surface + headless test + EN/Zh docs + changelog.wait_until_screen_stable).Merge with
--merge(no branch delete;devstays the working branch).