Conversation
Composes scroll_find.scroll_until_visible with actionability.act_when_ready so a 'click the off-screen row' step works in one call: scroll until the target is located, then run the actionability gate at its point and perform the action. ScrollPlan bundles the scroll search + locator/scroller seams to keep the call within the argument limit; the actionability probes and gate config are injectable, so the whole flow is testable without a screen.
…batch Add act_in_view: scroll a target into view, then act when actionable
…y gate act_when_ready only waits-then-acts. Real flows need two more modes Playwright codified: trial (run every actionability check but DON'T act - a side-effect-free dry run) and force (skip checks, act now). act_with_mode adds both alongside the default auto, over the same injectable seams as the gate, so each mode is testable without a screen. Reuses wait_actionable.
Add act_with_mode: trial and force action modes over the actionability gate
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 37 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release — ROUND-15 input-fidelity lane (completion)
Two features that close the input-fidelity lane (now 7/7), both previously deferred for solvable reasons (not un-verifiability) and now shipped at the full quality bar. Pure/injectable cores, full 5-layer wiring, headless tests, EN/Zh docs; merged to dev CI-green first try.
act_in_view(Add act_in_view: scroll a target into view, then act when actionable #451): composescroll_until_visible+act_when_ready— scroll an off-screen target into view, then gate on actionability before acting.ScrollPlanbundles the scroll seams to keep the call within the argument limit (the original deferral reason).act_with_mode(Add act_with_mode: trial and force action modes over the actionability gate #452): Playwright-style trial (gate but don't act — dry run) and force (act without checks) modes over the actionability gate, alongside the default auto.ROUND-15 status: native-UIA, perception, and input-fidelity lanes all COMPLETE; only
tray_icons/virtual_desktopremain, deferred as un-verifiable fragile OS paths. Package stays Qt-free; everything tested without a screen via injected seams.