Allow uint64 indices in dpt.take_along_axis and dpt.put_along_axis#1934
Merged
ndgrigorian merged 2 commits intomasterfrom Dec 13, 2024
Merged
Allow uint64 indices in dpt.take_along_axis and dpt.put_along_axis#1934ndgrigorian merged 2 commits intomasterfrom
dpt.take_along_axis and dpt.put_along_axis#1934ndgrigorian merged 2 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_323 ran successfully. |
Collaborator
Contributor
|
Overall this looks good to me, modulo nits. @vtavana It would be nice if an issue existed motivating this change. |
Contributor
|
Created issue #1936 which is now resolved with this PR. Thank you, @ndgrigorian! |
Make tests more maintenance-friendly
oleksandr-pavlyk
approved these changes
Dec 13, 2024
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_331 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes allowing indices of type
uint64intake_along_axisandput_along_axis.With current behavior, these functions build a list of indices using the default index type. If the input indices are
uint64and the input array is of dimension greater than 1, when the padded indices are constructed, the function will fail if the default index type isint64.Edit: Closes gh-1936