Implement `tensor.isin` by ndgrigorian · Pull Request #2098 · IntelPython/dpctl

ndgrigorian · 2025-06-06T08:54:47Z

This PR proposes an implementation for isin, a function likely coming to a future array API specification, which leverages a similar kernel to the implementation of searchsorted

This implementation uses the searchsorted kernel to check if the value has a position in the array. If that position is the number of elements in the array, it is not a member. Otherwise, if arr[pos] == val for some array arr being searched for value val, then val is a member.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2025-06-06T09:31:48Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2025-06-06T09:40:22Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_8 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

coveralls · 2025-06-06T09:40:36Z

coverage: 85.262% (+0.05%) from 85.208%
when pulling 68bc84e on feature/searchsorted-based-isin
into 3091e5b on master.

github-actions · 2025-06-06T23:26:19Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_10 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

dpctl/tensor/_set_functions.py

ndgrigorian · 2025-06-11T22:14:55Z

@antonwolfy
implementation is updated and now permits Python scalars in second argument

tests still need to be added, but isin itself is ready for review

github-actions · 2025-06-11T22:55:11Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_17 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

dpctl/tensor/CMakeLists.txt

dpctl/tensor/_set_functions.py

dpctl/tensor/libtensor/source/sorting/isin.cpp

dpctl/tensor/libtensor/include/kernels/sorting/isin.hpp

dpctl/tensor/_set_functions.py

github-actions · 2025-06-16T08:56:49Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_18 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-16T21:51:25Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_22 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-16T22:17:02Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_23 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-17T07:08:12Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_24 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-17T08:30:21Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_23 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

dpctl/tensor/_set_functions.py

dpctl/tests/test_tensor_isin.py

github-actions · 2025-06-17T21:17:04Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_24 ran successfully.
Passed: 1112
Failed: 9
Skipped: 119

github-actions · 2025-06-17T22:16:52Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_26 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-17T23:04:20Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_27 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-18T06:36:39Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_30 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-18T20:50:10Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_35 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-06-23T07:29:09Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_58 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

allows these comparisons to be shared outside of sorting more conveniently

github-actions · 2025-09-17T17:57:20Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_153 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

dpctl/tensor/_set_functions.py

github-actions · 2025-09-17T20:02:20Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_157 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

antonwolfy

Thank you @ndgrigorian, no more comments from me

github-actions · 2025-09-17T20:25:54Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_158 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

github-actions · 2025-09-17T20:54:43Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_158 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

github-actions · 2025-09-17T21:24:11Z

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_161 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from 1805102 to 5355fb8 Compare June 6, 2025 22:41

antonwolfy reviewed Jun 10, 2025

View reviewed changes

dpctl/tensor/_set_functions.py Outdated Show resolved Hide resolved

dpctl/tensor/_set_functions.py Outdated Show resolved Hide resolved

dpctl/tensor/_set_functions.py Outdated Show resolved Hide resolved

dpctl/tensor/_set_functions.py Outdated Show resolved Hide resolved

ndgrigorian marked this pull request as ready for review June 11, 2025 22:15

ndgrigorian requested review from vlad-perevezentsev and vtavana as code owners June 11, 2025 22:15

ndgrigorian requested a review from antonwolfy June 11, 2025 22:20

antonwolfy reviewed Jun 11, 2025

View reviewed changes

ndgrigorian requested a review from antonwolfy June 17, 2025 06:24

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from b3822f3 to f7e0967 Compare June 17, 2025 07:40

antonwolfy reviewed Jun 17, 2025

View reviewed changes

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from 8f19cb5 to 3cf7445 Compare June 17, 2025 21:32

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from 3cf7445 to 7c6a4be Compare June 17, 2025 22:20

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from 16c63e4 to 23c61a8 Compare June 18, 2025 20:06

ndgrigorian added 9 commits September 17, 2025 10:08

Add test for combinations of dtypes as inputs to isin

5b877c8

Add compute follows data test for isin

538176c

Add isin to rendered docs

0cd24f5

Test that isin output is C-contiguous when input is strided

0070331

improve formatting of isin docstring

2ebb3a1

move rich_comparisons.hpp into utils

26f68d2

allows these comparisons to be shared outside of sorting more conveniently

factor out compare template param in isin

365c3b4

add missing includes to rich_comparisons

44661ba

drop unused includes in isin kernel implementation

62a9fa4

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from a8d9474 to 62a9fa4 Compare September 17, 2025 17:16

ndgrigorian requested a review from antonwolfy September 17, 2025 17:21

ndgrigorian added 2 commits September 17, 2025 12:18

validate that invert kwarg is boolean

ff68bca

add a test for input validation of invert

e28e1aa

antonwolfy reviewed Sep 17, 2025

View reviewed changes

dpctl/tensor/_set_functions.py Outdated Show resolved Hide resolved

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from b61f09e to 1ac19ae Compare September 17, 2025 20:14

antonwolfy previously approved these changes Sep 17, 2025

View reviewed changes

make invert bool type check stricter

68bc84e

ndgrigorian dismissed antonwolfy’s stale review via 68bc84e September 17, 2025 20:44

ndgrigorian force-pushed the feature/searchsorted-based-isin branch from 1ac19ae to 68bc84e Compare September 17, 2025 20:44

ndgrigorian requested a review from antonwolfy September 17, 2025 20:44

antonwolfy approved these changes Sep 17, 2025

View reviewed changes

ndgrigorian enabled auto-merge September 17, 2025 23:15

ndgrigorian disabled auto-merge September 17, 2025 23:15

ndgrigorian merged commit 878cc19 into master Sep 17, 2025
85 of 99 checks passed

ndgrigorian deleted the feature/searchsorted-based-isin branch September 17, 2025 23:17

Conversation

ndgrigorian commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

coveralls commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ndgrigorian commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

antonwolfy left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

ndgrigorian commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

coveralls commented Jun 6, 2025 •

edited

Loading