Remove python-gil requirement and enable free-threaded Python#2250
Merged
Conversation
ndgrigorian
changed the base branch from
master
to
feature/uncouple-tensor-from-dpctl
ndgrigorian
force-pushed
the
feature/uncouple-tensor-from-dpctl
branch
from
dcac1f6 to
e450664
Compare
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
from
085aece to
5dda977
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
4 times, most recently
from
82e9a5e to
a1d36ce
Compare
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
Collaborator
Author
|
@antonwolfy @vlad-perevezentsev |
ndgrigorian
force-pushed
the
feature/uncouple-tensor-from-dpctl
branch
2 times, most recently
from
6a5046b to
7d8bbc8
Compare
ndgrigorian
force-pushed
the
feature/uncouple-tensor-from-dpctl
branch
2 times, most recently
from
b610ee3 to
dd74214
Compare
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
from
1b70ce6 to
1bc9c3d
Compare
Collaborator
|
coverage: 75.677% (+0.05%) from 75.632% — feature/enable-free-threaded-python into master |
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
5 times, most recently
from
732f37d to
df6f452
Compare
vlad-perevezentsev
previously approved these changes
Jun 3, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Collaborator
There was a problem hiding this comment.
No more comments from my side
LGTM
Thank you @ndgrigorian
vchamarthi
reviewed
Jun 9, 2026
dpctl_capi singleton intiailization could cause deadlocks with updated order manager
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
from
e536e7b to
61e7697
Compare
ndgrigorian
force-pushed
the
feature/enable-free-threaded-python
branch
from
e25bea2 to
bd96827
Compare
antonwolfy
previously approved these changes
Jun 18, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM!
I left a couple minor nits more:
antonwolfy
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the required
python-gildependency from the dpctl conda package workflow and enables free-threaded Python in extension modulesAdjustments are made to the
SequentialOrderManagerclass such that the class is safe in free-threaded, including mutexes in the C++ class as a fall-back in case of (not recommended) simultaneous access to its members and methodsSequentialOrderManager now maintains thread-local storage for individual queue-to-manager-maps, such that each thread has its own manager per queue.
Queue and device caching, meanwhile, are global, to create a concept of default queues and devices that allows operations in extensions like dpnp (which rely on queues being the same for compute follows data) to operate on data passed between threads without copy.
In the futue, per-thread-queues and devices may prove more efficient, in which case, extensions will be asked to be made more robust (checking that context and device are the same, not using queue as a shortcut).
This PR builds on top of work already done removing the tensor submodule, which is pending migration to dpnp