[Fix] Update flush cache worker broadcast - #2071
Open
matrix72c wants to merge 1 commit into
Open
Conversation
matrix72c
force-pushed
the
fix/flush-cache-broadcast
branch
from
September 7, 2026 03:52
6b0c75d to
1fffeb4
Compare
matrix72c
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RolloutController.flush_cache()to use the lifecycle-aware_broadcast_to_workershelper after the worker broadcast refactorRoot cause
The upstream flush-cache feature added a call to
_broadcast_to_active_workers, while the later controller refactor renamed that helper to_broadcast_to_workersand missed this caller.Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONPATH=.../xtuner sandbox_rl/.venv/bin/python -m pytest -q tests/rl/test_rollout_logic.py(61 passed)