Skip to content

Change pkgs.system to pkgs.stdenv.hostPlatform.system in cardano-node-service.nix#6414

Merged
disassembler merged 1 commit intoIntersectMBO:masterfrom
zeme-wana:system-to-hostplatform
Jan 30, 2026
Merged

Change pkgs.system to pkgs.stdenv.hostPlatform.system in cardano-node-service.nix#6414
disassembler merged 1 commit intoIntersectMBO:masterfrom
zeme-wana:system-to-hostplatform

Conversation

@zeme-wana
Copy link
Contributor

@zeme-wana zeme-wana commented Jan 22, 2026

Description

This fixes the following evaluation warning on recent nixpkgs releases:

evaluation warning: 'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'

We use the cardano-node-service.nix module in our NixOS config like so:

  imports = [
    ./ax41-nvme.nix
    ./common.nix
    "${inputs.cardano-node}/nix/nixos/cardano-node-service.nix"
  ];

This PR makes the warning disappear.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@zeme-wana zeme-wana requested a review from a team as a code owner January 22, 2026 08:49
@zeme-wana zeme-wana force-pushed the system-to-hostplatform branch from 5a3cec6 to 9924d9e Compare January 30, 2026 10:11
@zeme-wana zeme-wana force-pushed the system-to-hostplatform branch from 9924d9e to 51a3251 Compare January 30, 2026 10:16
@disassembler disassembler added this pull request to the merge queue Jan 30, 2026
Merged via the queue into IntersectMBO:master with commit 378b3fb Jan 30, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants