Ship a portable silent launcher instead of a local-only one - #25
Merged
Conversation
The launcher was gitignored as machine-specific because it hard-coded C:\pixelcat twice. When that folder was renamed the desktop shortcut and the autostart entry both broke, and the only symptom was a Windows Script Host box saying the script file could not be found, or on login nothing starting at all. It resolves the project from its own location now, so moving or renaming the folder cannot leave it pointing at nothing, and a missing electron says the dependencies were never installed rather than failing mute. That removes the reason it was local-only, so it is tracked, and it drops the pixelcat name the rest of the app already left behind. Worth having at all because `npm start` leaves a console window sitting behind the pet, which is not what you want on a shortcut.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run-from-source launcher was gitignored as machine-specific, because it
hard-coded
C:\pixelcattwice:When that folder was renamed, the desktop shortcut and the
HKCU\...\Runautostart entry both broke. The only symptom was a Windows Script Host box
saying the script file could not be found, and on login, nothing starting at
all.
It resolves the project from
WScript.ScriptFullNamenow, so moving orrenaming the folder cannot leave it pointing at nothing, and a missing
electronreports that dependencies were never installed instead of failingmute. That removes the reason it was local-only, so it is tracked, and it drops
the
pixelcatname the rest of the app already left behind.Worth shipping at all because
npm startleaves a console window sittingbehind the pet, which is not what you want on a desktop shortcut. README says
how to point one at it.
Testing
wscript.exe launch-pixelpets.vbsexactly as the shortcutdoes: app starts, one main electron process on the project path
npm test127 pass,npm run lintclean