Fix install + dashboard rendering with bundled demo data#18
Conversation
|
Some issues are fixed by previous PRs that have not yet been merged. (e.g. the conversion to plotly fixes crash in makeCrossModelPerformancePlot legend with single strat value, Populate Model holdouts Bug/Drug selectors). With regard to amRviz/amRshiny specifically if folks could review & approve in this order: #18— install + dashboard rendering fix from @Alex McKim After #20 merges I will need to rebase #16 onto the new main and update any 'amrShiny' -> 'amRviz' references in the test files and then #16 could be reviewed after that process is completed. If those PRs are merged I can likely just close #14 without merging and open up small follow-up PRs for the minor UI changes (color palette, home page redesign, etc.) that introduced. |
eboyer221
left a comment
There was a problem hiding this comment.
Approving, I pulled the branch and ran locally. Confirmed the Model Holdouts Bug dropdown now populates, and the country choropleth renders correctly.
Description
This PR's focus is to allow the shiny app to work on the included external data, and thus user, input, when before it was defaulting to ESKAPE pathogens. This led to the dashboards being broken and not usable
ComplexHeatmap::draw(ht...)calls withreqto deal with no data render on empty panelsmakeCrossModelPerformancePlot()which appears when there is only one unique strat valueWhat kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.