Skip to content

Update to Valhalla - #692

Open
koppor wants to merge 17 commits into
mainfrom
ea-valhalla
Open

koppor wants to merge 17 commits into
mainfrom
ea-valhalla

Conversation

@koppor

@koppor koppor commented Aug 3, 2024

Copy link
Copy Markdown
Member

Prepares the usage of Valhalla.

Reason: String!. See https://bugs.openjdk.org/browse/JDK-8303099.

Won't work, because of gradle toolchain lacking support for JDK23. See https://docs.gradle.org/current/userguide/compatibility.html.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor

koppor commented Aug 3, 2024

Copy link
Copy Markdown
Member Author

Err, even though it should not work, there are artifacts produced at https://github.com/koppor/jabref/actions/runs/10223502907?pr=692

@koppor

koppor commented Aug 4, 2024

Copy link
Copy Markdown
Member Author

Runs:

image

I only don't get, why 5.12 is displayed as version - and not v5.15

test and others added 12 commits July 27, 2026 16:22
Runs daily (and on demand) and merges a configurable list of branches from
JabRef/jabref and JabRef/jabref-koppor on top of the existing
all-branches-merged branch.

Branches that have disappeared and branches that conflict are reported via
::warning and skipped, so one dead or conflicting branch does not stop the
remaining merges.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AiaGjSfwh9uqDGtbW8tLfU
The branch only exists on JabRef/jabref, not on the koppor fork, so the
previous koppor/ entry warned and skipped on every run.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AiaGjSfwh9uqDGtbW8tLfU
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AiaGjSfwh9uqDGtbW8tLfU
The branch was deleted upstream after JabRef#16151 merged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016Ww52ZvR7zTL8ZnLHBWhkQ
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014f69UBH8mjRLVQHs7CgnFj

koppor commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

🤖 Generated with Claude Code

Merging main into this branch conflicts in 1 file. I did not push a resolution.

.github/workflows/deployment-jdk-ea.yml is a modify/delete: main deleted it in the multi-project split (JabRef#12990, 518f61f4fc) and has no EA/Valhalla workflow left at all. Keeping this branch's copy would resurrect a workflow written against the old single-module Gradle build.

Whether the EA deployment workflow should come back, rewritten for the module layout, is a human call rather than a conflict resolution.


Generated by Claude Code

koppor and others added 2 commits August 28, 2026 05:10
# Conflicts:
#	.github/workflows/deployment-jdk-ea.yml

koppor commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

🤖 Generated with Claude Code

Merged main into ea-valhalla to resolve the merge conflict.

Conflicting file: .github/workflows/deployment-jdk-ea.yml — a modify/delete conflict. main deleted the workflow in the multi-project build change (JabRef#12990); this PR's only content is its edit to that same file, so I kept this branch's version rather than taking the deletion, which would have emptied the PR. Note the restored workflow still references the pre-split build.gradle layout, so it likely needs a follow-up to match the multi-project structure.

No build was run locally; this PR's CI is the compile check.


Generated by Claude Code

# Conflicts:
#	.github/workflows/update-experimental.yml

koppor commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

🤖 Generated with Claude Code

Merged main into ea-valhalla to resolve the merge conflict.

  • Conflicting file: .github/workflows/update-experimental.yml — an add/add conflict. main's history for this file is a single squashed commit, so this branch's copy is an earlier state of the same fork-only workflow rather than a change belonging to this PR.
  • Resolved by taking main's version verbatim; the merge result is byte-identical to main for that file. Nothing else in this PR touches it.

CI on this PR is the compile check.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants