Remove Future dependency and use built-in copy!#193
Merged
Conversation
Future.copy! is deprecated in Julia pre-release, causing CI failures since tests run with depwarn=error. Base.copy! has had the same resizing semantics since Julia 1.1, so Future is no longer needed. https://claude.ai/code/session_01SGAgzkbRVNAL51y3Fo9fni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the dependency on the
Futurepackage and replaces allFuture.copy!calls with the built-incopy!function from Base Julia. TheFuturemodule was being used solely for thecopy!function, which is now available in the standard library.Changes Made
import Futurestatement fromsrc/DynamicPolynomials.jlFuturefrom the[deps]section inProject.tomlFuture.copy!withcopy!across the codebase:src/mult.jl: 3 replacements inoperate_to!functionsrc/monomial_vector.jl: 2 replacements in__add_variables!functionsrc/poly.jl: 2 replacements inpolynomialclean_to!andmap_coefficients_to!functionssrc/mono.jl: 1 replacement in__add_variables!functionsrc/operators.jl: 1 replacement inoperate_to!functionsrc/subs.jl: 1 replacement in_subsmapfunctionImplementation Details
The
copy!function is part of Julia's Base library and provides the same functionality that was previously imported from theFuturepackage. This change simplifies dependencies while maintaining full backward compatibility with existing code.https://claude.ai/code/session_01SGAgzkbRVNAL51y3Fo9fni