Examples

[bramtayl]

@JeffFessler this is what I have so far

[bramtayl]

Just the second commit actually oops

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.12%. Comparing base (44d4ca3) to head (d90a483).
⚠️ Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
src/PortAudio.jl	0.00%	6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (44d4ca3) and HEAD (d90a483). Click for more details.

HEAD has 18 uploads less than BASE

Flag	BASE (44d4ca3)	HEAD (d90a483)
	30	12

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #107       +/-   ##
===========================================
- Coverage   97.42%   23.12%   -74.31%     
===========================================
  Files           2        2               
  Lines         350      333       -17     
===========================================
- Hits          341       77      -264     
- Misses          9      256      +247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bramtayl]

@ssfrr Ok, I give, I can't get the makie examples to run. I think you wrote them; can you help?

[ssfrr]

Can you be more specific about what isn’t working? Makie has changed a lot since this was written so I wouldn’t be surprised if all the makie stuff has to be basically rewritten from scratch

[bramtayl]

Well, one change I had to make to this and the other examples is to run them only for a certain amount of time. So I replaced the while isopen(scene[:screen]) block with something like

done = false
@sync begin
    @async while !done
        # do stuff
    end
    sleep(seconds)
    done = true
end

It doesn't help that I don't really understand FFT. I can paste the errors I get from running what I have if that would be helpful.

[JeffFessler]

Would it make sense to separate the Makie-related changes from the rest so that at least the rest of the examples could be updated, and then return to the Makie ones later when someone with Makie expertise has time for them?

[bramtayl]

Sure, we can do that.