Update benchmark.yml#161
Merged
Merged
Conversation
Enable posting benchmarking results as PR comments and run benchmarking action on pull_request_target
Contributor
Author
|
Hi @lostella, could you check this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous attempts to integrate AirspeedVelocity with the "commenting on PRs" feature might have failed because the action was triggered by the "pull_request" event rather than the "pull_request_target". The "pull_request_target" event has higher privileges, but AirspeedVelocity appears to incorporate sufficient safety countermeasures, as discussed in MilesCranmer/AirspeedVelocity.jl#142.
Unfortunately, this file needs to be merged to take effect and see if it really works.