Skip to content

loader: Change incompatible driver warning to debug level #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akien-mga wants to merge 1 commit into from
+2 −1
Closed

loader: Change incompatible driver warning to debug level #1937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion loader/loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6023,7 +6023,8 @@ VKAPI_ATTR VkResult VKAPI_CALL terminator_CreateInstance(const VkInstanceCreateI
res = VK_ERROR_OUT_OF_HOST_MEMORY;
goto out;
} else if (VK_SUCCESS != icd_result) {
loader_log(ptr_instance, VULKAN_LOADER_WARN_BIT, 0,
VkFlags log_level = VK_ERROR_INCOMPATIBLE_DRIVER == icd_result ? VULKAN_LOADER_DEBUG_BIT : VULKAN_LOADER_WARN_BIT;
loader_log(ptr_instance, log_level, 0,
Comment on lines +6026 to +6027

@akien-mga akien-mga Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this in a local variable as it was tricky otherwise to keep clang-format happy, the line would be slightly too long and it would throw 0, to its own line, which doesn't match the style used elsewhere.

Alternatively, this could be:

            loader_log(ptr_instance,
                       VK_ERROR_INCOMPATIBLE_DRIVER == icd_result ? VULKAN_LOADER_DEBUG_BIT : VULKAN_LOADER_WARN_BIT,
                       0,
                       "terminator_CreateInstance: Received return code %i from call to vkCreateInstance in ICD %s. Skipping "
                       "this driver.",
                       icd_result, icd_term->scanned_icd->lib_name);

"terminator_CreateInstance: Received return code %i from call to vkCreateInstance in ICD %s. Skipping "
"this driver.",
icd_result, icd_term->scanned_icd->lib_name);
Expand Down
Loading