Open
Conversation
Some of these aren't even valid utf-8, and python's open(foo,'r').read() raises UnicodeDecodeErrors.
I think these files were Windows-1252, but it's hard to tell.
kenrussell
reviewed
Mar 6, 2021
| uniform mat4 �m�����`�r�b�h�h; | ||
| // ‚±‚ê‚Í‚`‚r‚b‚h‚h‚Å‚Í‚È‚¢‚Å‚·B | ||
| // ‚s‚ˆ‚‰‚“@‚h‚“@‚m‚‚”@‚`‚r‚b‚h‚h | ||
| uniform mat4 ‚m‚‚”‚`‚r‚b‚h‚h; |
Member
There was a problem hiding this comment.
What exactly was the conversion done to these files? (I'm not an expert on file encodings.) Were they UTF-16 before and have been converted to UTF-8 now? Are we sure that the characters are interpreted the same way, for example when this shader is loaded? I see the meta tag above indicates the character set is UTF-8 so was the browser just being permissive before in loading UTF-16 characters?
Contributor
Author
There was a problem hiding this comment.
Oh yeah maybe? I can see here that it says "NotASCII" with weird codepoints, so that comes from somewhere!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More non-utf8 files in conformance-suites snapshots.
These make it trickier to operate on these snapshots, even though we shouldn't really be touching them much.
This is minimally invasive, and should be the correct equivalent to what we had before, so I'd like to take it against the snapshots anyway.
@kenrussell thoughts?