feat(claw): evaluate button-vs-card feature flag for PostHog experiment#1338
Open
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Open
feat(claw): evaluate button-vs-card feature flag for PostHog experiment#1338kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 77,877 tokens |
Moves useFeatureFlagVariantKey('button-vs-card') from ClawDashboard
(which renders for all users including those with existing instances)
to CreateInstanceCard (which only renders for users who haven't
provisioned yet). This scopes the experiment exposure to users who
can actually see the create CTA, avoiding population dilution.
jeanduplessis
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evaluates the
button-vs-cardPostHog feature flag inCreateInstanceCardso the SDK attaches$feature/button-vs-cardto subsequent events (includingclaw_create_instance_clicked). Without this, the cloud app's PostHog SDK never evaluates the flag, so the experiment gets 0 conversions even though users are clicking.The flag is evaluated in
CreateInstanceCard(notClawDashboard) so only users who can actually see the create CTA are marked as exposed.ClawDashboardalso renders for users with existing instances, mid-onboarding, or viewing settings — evaluating there would dilute the experiment population.Verification
oxfmton changed filesuseFeatureFlagVariantKeyis exported byposthog-js/react(v1.360.2)Visual Changes
N/A
Reviewer Notes
$feature/button-vs-cardto tracked events.CreateInstanceCardwithout coming through the landing page will get a variant assigned by the cloud app SDK. This is expected — PostHog uses the same hash for the same distinct_id, so the variant will be consistent.