fix(kiloclaw): remove delayed-billing start date that causes Stripe checkout failures#1363
Draft
jeanduplessis wants to merge 1 commit intomainfrom
Draft
fix(kiloclaw): remove delayed-billing start date that causes Stripe checkout failures#1363jeanduplessis wants to merge 1 commit intomainfrom
jeanduplessis wants to merge 1 commit intomainfrom
Conversation
…rial_end rejection STRIPE_KILOCLAW_BILLING_START was set to 2026-03-23 but Stripe requires trial_end to be at least 48h in the future, causing checkout failures for users. Since launch billing is imminent, remove the mechanism entirely rather than adding a buffer.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Reviewed by gpt-5.4-20260305 · 246,221 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STRIPE_KILOCLAW_BILLING_STARTenv var and thetrial_endlogic in checkout session creation. This mechanism deferred billing for pre-launch subscribers until March 23, but Stripe requirestrial_endto be at least 48 hours in the future — causing checkout failures for users as we approached that date.trial_endare still handled correctly by the existingtrialing→activestatus mapping.Verification
pnpm typecheck— passes across all workspace projectspnpm test -- src/routers/kiloclaw-billing-router.test.ts— 25/25 tests passVisual Changes
N/A
Reviewer Notes
.env.localstill containsSTRIPE_KILOCLAW_BILLING_START="2026-03-23"— should be removed manually (file edit was blocked by repo rules). The production env var should also be removed.trialing→activemapping instripe-handlers.tsis now only needed for legacy pre-launch subs. A TODO was added to remove it after ~2026-03-23 when those subscriptions transition.