fix(kilo-app): prevent flash of home screen before auth redirect#1465
Merged
fix(kilo-app): prevent flash of home screen before auth redirect#1465
Conversation
Splash screen was hidden and <Slot /> rendered the (app) route while router.replace to the login screen was still in flight. Compute redirect need synchronously, gate rendering on it, and only hide the splash screen once the user is on the correct route group.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 149,092 tokens |
jeanduplessis
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Slot />rendered the(app)route andSplashScreen.hideAsync()fired whilerouter.replaceto login was still in flight<Slot />rendering on it, and only hide splash screen once the user is on the correct route groupTest plan