Repository navigation
Conversation
|
|
||
| /** | ||
| * Read the `status` route parameter as one status kind. Returns null for an | ||
| * absent, repeated, or unknown value, so a stale or hand-written link never |
There was a problem hiding this comment.
SUGGESTION: Doc comment contradicts the implementation for a repeated parameter
The JSDoc says this "Returns null for an absent, repeated, or unknown value", but the implementation takes the first element of a repeated parameter (value[0]), and the unit test takes the first value of a repeated parameter asserts exactly that. The wording implies a repeated value is rejected, which is not the case, so a reader could wrongly rely on this to reject a hand-written link with a duplicate status param. Consider rewording to state that a repeated parameter uses its first value.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (9 files)
The status filter reuses the same Fix these issues in Kilo Cloud Reviewed by deepseek-v4.1-flash · Input: 98.4K · Output: 15.9K · Cached: 1.3M Review guidance: REVIEW.md from base branch |
What this change does
The Home screen shows a "Live now" card. The card lists agent counts by status:
Before this change, the counts were not selectable.
After this change, each status row is a button. Tap a row to open the Agents tab. The Agents tab shows only the agents with that status. A bar at the top of the list names the active status filter and the number of agents. Tap the X on the bar to clear the filter and show all agents again.
A zero-count row also opens the list. The list then shows the "No sessions match" state. The Clear action removes the filter.
Why
A user can see that 13 agents are idle. The user cannot find these agents. The user cannot settle them or close the agents that are done.
Closes #7396.
Implementation
glanceable-active-card.tsx: each count row is now a Pressable. A new requiredonPressStatusprop receives the status kind.agent-sessions-section.tsx:onPressStatusswitches to the Agents tab and sets astatusroute parameter. The existingSee allaction now clears that parameter.live-session-status-filter.ts: new helpers.parseStatusFilterKindvalidates the parameter.filterSessionsByStatusKindkeeps the sessions of one kind.session-status-filter-bar.tsx: new bar that names the active filter and clears it.session-list-screen.tsx: reads thestatusparameter, filters the live list, and draws the bar.The
statusparameter is transient. It is not stored. The user can always clear it.Tests
Checks
oxfmtis clean on the changed files.oxlintis clean on the changed files.check:i18n,check:plurals, andcheck:classespass.Ready for review.