Skip to content

test(python): release auth callbacks on unsubscribe - #368

Merged
swkeever merged 1 commit into
mainfrom
skeever/python-client-mutation-lifecycle
Sep 24, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/python-client-mutation-lifecycle

Conversation

@swkeever

@swkeever swkeever commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Unsubscribing from auth state must release the callback even while the subscription handle remains alive. This test pins that resource-cleanup guarantee and catches Mutmut's no-removal and wrong-key variants, which previously timed out in the full mutation gate.

Validation: poe checks passed (2,209 tests; 100% line and branch coverage; package and type checks). A fresh exact Mutmut run killed both affected mutants (2/2, no timeouts). The PR's mutation gate exercises the repository's required module set.

@swkeever

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T12:18:25.825228Z 37baae1 Manual request
🔒 Security Review ✅ Completed 2026-09-24T12:18:36.255805Z 37baae1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Provided git ref 37baae19260810506ce42ec2e294110b943b7729 does not exist
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@swkeever

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 37baae1926

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 37baae1926

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@swkeever
swkeever marked this pull request as ready for review September 24, 2026 12:20
@swkeever
swkeever requested a review from a team as a code owner September 24, 2026 12:20
@swkeever
swkeever merged commit fd100c3 into main Sep 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant