Skip to content

Fixed drop and take docs - #2027

Open
Allex-Nik wants to merge 8 commits into
masterfrom
take-drop-kdocs
Open

Fixed drop and take docs#2027
Allex-Nik wants to merge 8 commits into
masterfrom
take-drop-kdocs

Conversation

@Allex-Nik

@Allex-Nik Allex-Nik commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2018
Helps #898

  • Fix @return in the drop* functions (it was inverted, as if it was for take)
  • Clarify the docs of *While functions (so that they are easier to understand)
  • Add KDocs to some of the overloads
  • Add the See also section
  • Move samples to the samples module
  • Add new samples to the website to illustrate the DataColumn overloads that are now mentioned on the website

@Allex-Nik
Allex-Nik marked this pull request as ready for review August 19, 2026 14:44

@AndreiKingsley AndreiKingsley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Please also add references to fillNa/ fillNaN/ fillNulls in the dropNa/ dropNaN / dropNulls docs.

<!---FUN dropNullsWhereAllNullSelector-->

```kotlin
df.dropNulls(whereAllNull = true) { city and weight } // remove rows with nulls in both columns

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move code comment above the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix take/drop KDocs

2 participants