Skip to content

Fix JSON serialization for all-null value column - #2037

Open
chimission wants to merge 2 commits into
Kotlin:masterfrom
chimission:fix-value-json
Open

Fix JSON serialization for all-null value column#2037
chimission wants to merge 2 commits into
Kotlin:masterfrom
chimission:fix-value-json

Conversation

@chimission

Copy link
Copy Markdown

Fix #2035

}
} else {
true
allColumns.all { col ->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the same logic exists in extractArrayColumn() maybe it should be fixed there as well?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’ll fix that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toJson() drops row objects when a real "value" column contains only nulls

2 participants