[Core][Apps] Making visibility hidden by default by roigcarlo · Pull Request #13060 · KratosMultiphysics/Kratos

roigcarlo · 2025-01-29T16:02:40Z

📝 Description
This PR aims to unify the windows and Linux behavior making all symbols in Linux (gcc and llvm based compilers) hidden by default. This will probably help with linking times and linking restrictions (see llvm in win refusing to link targets with more than 65K symbols)

Since exporting template classes with definitions in sources works a bit different (finally i figured out how to make them visible!), some additional decorators will need to be added to several explicit instantiations.

Comments:

Changes in find_global_nodal_neighbours_for_entities_process.cpp are not strictly necessary, but is better this way (imo).
@KratosMultiphysics/dem DEM application was failing due to a forward declaration of the SphereElement. Please take a look (0e8e547)
@KratosMultiphysics/mpi There was an error in the AMGCSolve function as the header was never being used. I made it so it uses the header declaration and the source definition instead of using the definition as a header in the source. Please confirm this was the intended behavior.
@AlejandroCornejo CL is mostly yours check everything needed is exposed, I really don't know what is used from outside so I treid to make everything visible but maybe I am missing something used in other apps I don't have access to.

loumalouomega · 2025-01-29T16:05:20Z

You don't need to kodify KRATOS_API for non MSVC ?

matekelemen · 2025-01-30T00:21:27Z

Oh yes thank you! I got back into compile-heavy development again and was about to tear my nonexistent hair out during linking.

loumalouomega · 2025-01-30T08:05:20Z

Almost compiled, just Metis is failing apparently

roigcarlo · 2025-01-30T09:46:16Z

KRATOS_API

Should work as it is rn, I foresaw this when I did the Kratos api, but if some application gets grumpy I will touch it.

…the header definition, but the in place declaration omg... omg...)

…omplete type. If you want to to that you have to define that function after SphereElement

…nstructor

…_market_io.h

…ense_linear_solver_factory.cpp

…event crashes during compilation

loumalouomega · 2026-07-13T13:48:22Z

@roigcarlo now it compiles with Intel LLVM, I need to fix linux, but we did it!

…gister_kratos_components_for_geometry.h

…CSR format

…rsal using CSR format

…#14565) * added ReplaceIgnoreUndrainedByDrainageType * removed a value check for VAN_GENUCHTEN_GL * included a lock * removed mutex * added CalculateInverseBiotModuli with BulkModulusFluid input * added unit tests * corrected unit tests * removed unused function * removed duplication * removed GEO_DRAINAGE_TYPE in integration tests * response to the review * corrected Transient_Case tests * changed names * response to 2nd review comments

Removed PENALTY_ROTATION_FACTOR from material properties.

…clang-tidy suggestion (#14586)

…ationPointValuesToNodesProcess (#14581) * added Check * added unit tests for the introduced checks * moved checks to Check()

…antiations

roigcarlo added 2 commits January 29, 2025 16:16

Making visibility hidden in core

aa41c8d

I am invisible when nobody looks at me.

f60b899

matekelemen reviewed Jan 30, 2025

View reviewed changes

Comment thread CMakeLists.txt Outdated

roigcarlo added 12 commits January 30, 2025 11:52

Using cmake visibility setting

8d8e98b

Exposing most of CL template inception

4aa9903

Exposing missing core symbols needed by other CI apps

1ce99f5

Exposing needed symbols from StructuralMechanics

cddfd68

Exposing some bits from other apps needed elsewhere

d1bfa93

Enabling api for metis

0d8701f

Fixing metis exposure

1ee9d5c

Fixing exposure for mpi core

d1f63ea

Fixing trilinos exposure and correct use of AMGCSolve (was not using …

d3e5403

…the header definition, but the in place declaration omg... omg...)

Fixing swimming dem exposure

bf39ce1

Fixing dem exposure and fixing wrong use of a definition using an inc…

0e8e547

…omplete type. If you want to to that you have to define that function after SphereElement

Fixing hdf5 app exposure

273b799

roigcarlo marked this pull request as ready for review January 30, 2025 11:54

roigcarlo requested review from a team as code owners January 30, 2025 11:54

Fixing mapper mpi extension

af25d44

roigcarlo requested a review from a team as a code owner January 30, 2025 14:30

roigcarlo added 2 commits January 31, 2025 15:47

Exposing the symbol with 3ul explicitly

f80e604

GCC I expected more from you.

d3f9710

roigcarlo mentioned this pull request Feb 4, 2025

Boost upgrade from 1.74 -> 1.87 #13093

Closed

roigcarlo temporarily deployed to github-pages April 8, 2026 13:27 — with GitHub Actions Inactive

Merge branch 'master' into core/the-purge

e4776f3

loumalouomega temporarily deployed to github-pages July 13, 2026 06:41 — with GitHub Actions Inactive

Fix output variable type in FindGlobalNodalEntityNeighboursProcess co…

5037184

…nstructor

loumalouomega temporarily deployed to github-pages July 13, 2026 07:48 — with GitHub Actions Inactive

Add KRATOS_API macro to MatrixMarket I/O functions in trilinos_matrix…

00ac95f

…_market_io.h

loumalouomega temporarily deployed to github-pages July 13, 2026 10:08 — with GitHub Actions Inactive

loumalouomega added 3 commits July 13, 2026 15:09

Add KRATOS_API macro to KratosComponents template instantiations in d…

0763b25

…ense_linear_solver_factory.cpp

Refine visibility attributes for Windows platform in kratos_export_api.h

4cd9070

Disable Intel LLVM loop optimizer for specific files on Windows to pr…

1bc61d6

…event crashes during compilation

loumalouomega requested a review from a team as a code owner July 13, 2026 13:09

loumalouomega temporarily deployed to github-pages July 13, 2026 13:12 — with GitHub Actions Inactive

Add KRATOS_API macro to KratosComponents template instantiation in re…

be12660

…gister_kratos_components_for_geometry.h

loumalouomega temporarily deployed to github-pages July 13, 2026 14:17 — with GitHub Actions Inactive

loumalouomega and others added 12 commits July 18, 2026 09:25

Refactor ILU0Preconditioner to optimize sparse matrix handling using …

edfa50a

…CSR format

Refactor SkylineLUFactorizationSolver to optimize sparse matrix trave…

916cca0

…rsal using CSR format

[TrilinosApplication] Missing test_trilinos_mixed_generic_criteria.cpp

d84b631

Refactor header and test files for Trilinos mixed generic criteria

6b1411b

[Benchmark] Add linear solver benchmark implementation

47280b0

penalty rotation handling in coupling condition

de29a7b

update material properties in two_patch_cantilever_test

49c5239

Removed PENALTY_ROTATION_FACTOR from material properties.

fix the flag

6ba68dc

[GeoMechanicsApplication] replace push_back with emplace_back as per …

6c5aadb

…clang-tidy suggestion (#14586)

[GeoMechanicsApplication] added element Check in GeoExtrapolateIntegr…

8ddfbf5

…ationPointValuesToNodesProcess (#14581) * added Check * added unit tests for the introduced checks * moved checks to Check()

[MeshingApplication] add KRATOS_API macro to MmgModeler template inst…

2ba8459

…antiations

loumalouomega temporarily deployed to github-pages July 18, 2026 07:27 — with GitHub Actions Inactive

Merge branch 'master' into core/the-purge

6ddbff8

loumalouomega deployed to github-pages October 1, 2026 13:25 — with GitHub Actions View deployment

Navigation Menu

[Core][Apps] Making visibility hidden by default - #13060

[Core][Apps] Making visibility hidden by default #13060
roigcarlo wants to merge 114 commits into
masterfrom
core/the-purge

roigcarlo commented Jan 29, 2025 •

edited

Loading

Uh oh!

loumalouomega commented Jan 29, 2025

Uh oh!

matekelemen commented Jan 30, 2025

Uh oh!

Uh oh!

loumalouomega commented Jan 30, 2025

Uh oh!

roigcarlo commented Jan 30, 2025

Uh oh!

loumalouomega commented Jul 13, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

roigcarlo commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loumalouomega commented Jan 29, 2025

Uh oh!

matekelemen commented Jan 30, 2025

Uh oh!

Uh oh!

loumalouomega commented Jan 30, 2025

Uh oh!

roigcarlo commented Jan 30, 2025

Uh oh!

loumalouomega commented Jul 13, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

roigcarlo commented Jan 29, 2025 •

edited

Loading