Repository navigation
[RomApp] Use NumpyOutputProcess in RomManager rather than RomBasisOutputProcess - #14828
Merged
Rbravo555 merged 4 commits intoOct 7, 2026
Merged
Conversation
Rbravo555
marked this pull request as ready for review
October 2, 2026 14:50
Contributor
|
The changes look good to me. Are we using RomBasisOutputProcess anywhere else still? Otherwise, why not remove it completely here? |
Member
Author
I've erased the references to the RomBasisOutputProcess, but kept the file itself, because it is used in a test in the Co-Simulation application. In order to avoid adding Co-simulation into this PR, I added a deprecation warning to the class. In a future PR we can erase the class and modify the Co-Simulation test that uses it. |
Rbravo555
deleted the
rom/rom_manager_use_numpy_output_no_basis_process
branch
October 7, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
For a while, the
RomManagercontained the following comment:This PR introduces direct snapshot handling inside
RomManager, eliminating the reliance onRomBasisOutputProcessand avoiding holding snapshots of a single simulation in RAM unnecessarily.🆕 Changelog
RomBasisOutputProcessto store snapshots inRomManager.RomManager(mirroringRomBasisOutputProcess).SetUpSimulationInstanceto give precedence to parameters passed byRomManager.