Skip to content

[RomApp] Use NumpyOutputProcess in RomManager rather than RomBasisOutputProcess - #14828

Merged
Rbravo555 merged 4 commits into
masterfrom
rom/rom_manager_use_numpy_output_no_basis_process
Oct 7, 2026
Merged

Rbravo555 merged 4 commits into
masterfrom
rom/rom_manager_use_numpy_output_no_basis_process

Conversation

@Rbravo555

@Rbravo555 Rbravo555 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

📝 Description

For a while, the RomManager contained the following comment:

# FIXME:
# - Use a method (upcoming) for smoothly retrieving solutions. In here we are using the RomBasisOutput process in order to store the solutions

This PR introduces direct snapshot handling inside RomManager, eliminating the reliance on RomBasisOutputProcess and avoiding holding snapshots of a single simulation in RAM unnecessarily.

Note: Future PRs will address the SVD computation for full scalability and usability. In this PR, although snapshots are flushed every step (or at a user-defined interval), they are still loaded back into RAM to compute the SVD. A future PR will introduce an alternative using partitioned methods or libraries like dask or dislib.


🆕 Changelog

  • Refactor: Stopped using RomBasisOutputProcess to store snapshots in RomManager.
  • Feature: Implemented SVD logic directly within RomManager (mirroring RomBasisOutputProcess).
  • Fix: Modified SetUpSimulationInstance to give precedence to parameters passed by RomManager.

@Rbravo555
Rbravo555 marked this pull request as ready for review October 2, 2026 14:50
@Rbravo555
Rbravo555 requested a review from a team as a code owner October 2, 2026 14:50
@NicolasSR

Copy link
Copy Markdown
Contributor

The changes look good to me. Are we using RomBasisOutputProcess anywhere else still? Otherwise, why not remove it completely here?

@Rbravo555

Rbravo555 commented Oct 6, 2026 •

Copy link
Copy Markdown
Member Author

The changes look good to me. Are we using RomBasisOutputProcess anywhere else still? Otherwise, why not remove it completely here?

I've erased the references to the RomBasisOutputProcess, but kept the file itself, because it is used in a test in the Co-Simulation application. In order to avoid adding Co-simulation into this PR, I added a deprecation warning to the class. In a future PR we can erase the class and modify the Co-Simulation test that uses it.

@Marco1410 Marco1410 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Rbravo555
Rbravo555 merged commit 35d16b1 into master Oct 7, 2026
10 checks passed
@Rbravo555
Rbravo555 deleted the rom/rom_manager_use_numpy_output_no_basis_process branch October 7, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants