feat: emit distinct emergency withdraw event - #1440
Open
silentgeckoaudit3801 wants to merge 3 commits into
Open
Conversation
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
this one is still a real gap, main's emergency_withdraw emits no distinct event, so the approach is right. but the branch is based on the old function signature:
- rebase onto main and adapt to the new emergency_withdraw(..., min_assets_out) signature (it now forwards to redeem_shares with min_assets_out).
- update the test's emergency_withdraw call accordingly.
- consider including the withdrawn asset amount in the event data alongside shares_burned, for parity with the regular Withdraw event.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
This PR adds a machine-distinguishable EmergencyWithdraw event for the contracts/lending_pool/src/lib.rs::emergency_withdraw path while leaving normal Withdraw emission and fund-movement mechanics unchanged.
Changes:
Validation: static GitHub API/source inspection only; local Soroban/Rust tests were not run in this environment to avoid installing or executing additional toolchains.