fix(loan_manager): correct oracle rate sanity check condition in comp… - #1477
Open
barry01-hash wants to merge 1 commit into
Open
fix(loan_manager): correct oracle rate sanity check condition in comp…#1477barry01-hash wants to merge 1 commit into
barry01-hash wants to merge 1 commit into
Conversation
…ute_interest_rate The sanity check meant to reject an oracle rate that falls outside the min/max band could never trigger because && was used instead of ||. A u32 value cannot be simultaneously less than min_rate AND greater than max_rate, so the condition was always false and the intended fallback branch was dead code. A stale or compromised oracle could push the rate to zero (free loans) or to an extreme value without being caught. Changed && to || so the check correctly triggers when the oracle rate is below the minimum OR above the maximum band. Fixes LabsCrypt#631. File: contracts/loan_manager/src/lib.rs Function: compute_interest_rate
Author
|
Please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1297
…ute_interest_rate
The sanity check meant to reject an oracle rate that falls outside the min/max band could never trigger because && was used instead of ||. A u32 value cannot be simultaneously less than min_rate AND greater than max_rate, so the condition was always false and the intended fallback branch was dead code.
A stale or compromised oracle could push the rate to zero (free loans) or to an extreme value without being caught.
Changed && to || so the check correctly triggers when the oracle rate is below the minimum OR above the maximum band.
Fixes #631.
File: contracts/loan_manager/src/lib.rs
Function: compute_interest_rate
Pull Request Checklist
Please ensure your PR follows these steps, mirroring our
CONTRIBUTING.mdguidelines.CONTRIBUTING.mddocument.