[lua] Fix Blue Magic from skipping MDT#10302
Open
Skold177 wants to merge 1 commit into
Open
Conversation
Adds calculateDamageAdjustment to the applySpellDamage function in Blue Magic so it honors MDT.
Xaver-DaRed
reviewed
Jun 13, 2026
| return dmg | ||
| end | ||
|
|
||
| dmg = math.floor(dmg * xi.combat.damage.calculateDamageAdjustment(target, false, true, false, false)) |
Contributor
There was a problem hiding this comment.
Blue magic needs the same treatment regular magic got.
This function (not the MDT function, the function youve placed in) would equate to the "final magic adjustment" step in the old magic system.
This would not be the step to place it.
I also have doubts about physical, breath and ranged blue spells use MDT indiscriminatedly. And even if it did, we would still need to check if the other "damage taken" forms affect it.
|
At least for Breath BLU magic, this is testable against Jourm and Khim, who have +50 and -50 respectively according to Jimmay's sheet. Find dude --> breathe on dude --> observe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Steps to test these changes
Use 1000 Needles, see MDT works against it now.