Feature#86 add unit test support for business / mappers functions

front/src/pods/embalse-search/embalse-search.mapper.spec.ts

@@ -0,0 +1,80 @@
+import { describe, it, expect } from "vitest";
+import { mapEmbalseToSearch } from "./embalse-search.mapper";
+import type { Embalse } from "db-model";
+
+describe("mapEmbalseToSearch", () => {
+  it("should map embalse to search model correctly", () => {
+    const mockEmbalse: Embalse = {
+      _id: "test-id-123",
+      nombre: "Albarracín",
+      provincia: "Teruel",
+    } as Embalse;
+
+    const result = mapEmbalseToSearch(mockEmbalse);
+
+    expect(result).toEqual({
+      slug: "test-id-123",
+      name: "Albarracín (Teruel)",
+    });
+  });
+
+  it("should handle empty province", () => {
+    const mockEmbalse: Embalse = {
+      _id: "test-id-456",
+      nombre: "Embalse Test",
+      provincia: "",
+    } as Embalse;
+
+    const result = mapEmbalseToSearch(mockEmbalse);
+
+    expect(result).toEqual({
+      slug: "test-id-456",
+      name: "Embalse Test ()",
+    });
+  });
+
+  it("should handle null province", () => {
+    const mockEmbalse: Embalse = {
+      _id: "test-id-789",
+      nombre: "Embalse Test",
+      provincia: null,
+    } as Embalse;
+
+    const result = mapEmbalseToSearch(mockEmbalse);
+
+    expect(result).toEqual({
+      slug: "test-id-789",
+      name: "Embalse Test (null)",
+    });
+  });
+
+  it("should handle special characters in name and province", () => {
+    const mockEmbalse: Embalse = {
+      _id: "test-id-special",
+      nombre: "Cueva de la Mora",
+      provincia: "Huelva",
+    } as Embalse;
+
+    const result = mapEmbalseToSearch(mockEmbalse);
+
+    expect(result).toEqual({
+      slug: "test-id-special",
+      name: "Cueva de la Mora (Huelva)",
+    });
+  });
+
+  it("should handle numeric ID", () => {
+    const mockEmbalse: Embalse = {
+      _id: "12345",
+      nombre: "La Viñuela",
+      provincia: "Málaga",
+    } as Embalse;
+
+    const result = mapEmbalseToSearch(mockEmbalse);
+
+    expect(result).toEqual({
+      slug: "12345",
+      name: "La Viñuela (Málaga)",
+    });
+  });
+});

front/src/pods/embalse/embalse.mapper.spec.ts

@@ -0,0 +1,194 @@
+import { describe, it, expect } from "vitest";
+import { mapEmbalseToReservoirData } from "./embalse.mapper";
+import type { Embalse } from "db-model";
+
+describe("mapEmbalseToReservoirData", () => {
+  const mockEmbalseBase: Partial<Embalse> = {
+    _id: "test-id",
+    nombre: "Albarracín",
+    capacidad: 1000,
+    provincia: "Teruel",
+    cuenca: { nombre: "Júcar", _id: "cuenca-id" },
+  };
+
+  it("should prioritize SAIH data over AEMET when both are available", () => {
+    // Arrange
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: 800,
+      fechaMedidaAguaActualSAIH: new Date("2024-01-15"),
+      aguaActualAemet: 600,
+      fechaMedidaAguaActualAemet: new Date("2024-01-10"),
+    } as Embalse;
+
+    // Act
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    // Assert
+    expect(result.currentVolume).toBe(800);
+    expect(result.measurementDate).toBe("15/01/2024");
+  });
+
+  it("should use AEMET data when SAIH is null", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: null,
+      fechaMedidaAguaActualSAIH: null,
+      aguaActualAemet: 600,
+      fechaMedidaAguaActualAemet: new Date("2024-01-10"),
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.currentVolume).toBe(600);
+    expect(result.measurementDate).toBe("10/01/2024");
+  });
+
+  it("should set currentVolume to 0 when both water measurements are null", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: null,
+      fechaMedidaAguaActualSAIH: null,
+      aguaActualAemet: null,
+      fechaMedidaAguaActualAemet: null,
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.currentVolume).toBe(0);
+    expect(result.measurementDate).toBe("");
+  });
+
+  it("should format date correctly from Date object", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: 500,
+      fechaMedidaAguaActualSAIH: new Date("2024-12-25"),
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.measurementDate).toBe("25/12/2024");
+  });
+
+  it("should format date correctly from string", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: 500,
+      fechaMedidaAguaActualSAIH: new Date("2024-12-25T10:30:00Z"),
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.measurementDate).toBe("25/12/2024");
+  });
+
+  it("should handle invalid date string", () => {
+    const mockEmbalse = {
+      ...mockEmbalseBase,
+      aguaActualSAIH: 500,
+      fechaMedidaAguaActualSAIH: "invalid-date",
+    } as unknown as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.measurementDate).toBe("");
+  });
+
+  it("should handle null/undefined dates", () => {
+    const testCases = [
+      { fecha: null, description: "null date" },
+      { fecha: undefined, description: "undefined date" },
+    ];
+
+    testCases.forEach(({ fecha, description }) => {
+      const mockEmbalse: Embalse = {
+        ...mockEmbalseBase,
+        aguaActualSAIH: 500,
+        fechaMedidaAguaActualSAIH: fecha,
+      } as Embalse;
+
+      const result = mapEmbalseToReservoirData(mockEmbalse);
+      expect(result.measurementDate).toBe(``);
+    });
+  });
+
+  it("should map cuenca correctly when cuenca exists", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      cuenca: { nombre: "Tajo" },
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.datosEmbalse.cuenca).toBe("Tajo");
+  });
+
+  it("should handle null cuenca", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      cuenca: null,
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.datosEmbalse.cuenca).toBe("");
+  });
+
+  it("should handle missing cuenca", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+    } as Embalse;
+    delete (mockEmbalse as any).cuenca;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.datosEmbalse.cuenca).toBe("");
+  });
+
+  it("should map all fields correctly", () => {
+    const mockEmbalse: Embalse = {
+      _id: "test-id",
+      nombre: "La Viñuela",
+      capacidad: 1500,
+      aguaActualSAIH: 750,
+      fechaMedidaAguaActualSAIH: new Date("2024-06-15"),
+      provincia: "Málaga",
+      cuenca: { nombre: "Mediterránea" },
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result).toEqual({
+      nombre: "La Viñuela",
+      currentVolume: 750,
+      totalCapacity: 1500,
+      measurementDate: "15/06/2024",
+      datosEmbalse: {
+        cuenca: "Mediterránea",
+        provincia: "Málaga",
+        municipio: "",
+        rio: "",
+        embalsesAguasAbajo: 0,
+        tipoDePresa: "",
+        anioConstruccion: 0,
+        superficie: 0,
+        localizacion: "",
+      },
+      reservoirInfo: {
+        Description: "",
+      },
+    });
+  });
+
+  it("should handle missing provincia", () => {
+    const mockEmbalse: Embalse = {
+      ...mockEmbalseBase,
+      provincia: null,
+    } as Embalse;
+
+    const result = mapEmbalseToReservoirData(mockEmbalse);
+
+    expect(result.datosEmbalse.provincia).toBe("");
+  });
+});