Open
Conversation
…ich can be used to produce ERF files.
Liareth
reviewed
Dec 1, 2019
| // A vector of resources contained within this ERF. | ||
| std::vector<ErfResource> m_Resources; | ||
|
|
||
| char m_FileType[4]; |
Owner
There was a problem hiding this comment.
Can we change this (and the other one) to std:array<char, 4>?
Liareth
reviewed
Dec 1, 2019
|
|
||
| std::string ext = std::filesystem::path(out_path).extension().string().substr(1); | ||
| std::transform(std::begin(ext), std::end(ext), std::begin(ext), ::toupper); | ||
| std::memcpy(erf.GetFileType(), ext.c_str(), 3); |
Owner
There was a problem hiding this comment.
Please could we add a function to Resource.hpp to map between resource type and file type? Like: std::array<char, 4> FiletypeFromResource(ResourceType res).
Contributor
Author
|
will address soon. |
…ich was usually fine on Windows because of CRLF, but would skip empty lines on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new tool too, ERF packer.
btw, I've noticed the Friendly:: API often assumes implementation knowledge. It's worse with these changes (because I'm exposing FileType). Maybe that's not an issue?