fix: Add null check in EnsureNull method#930
Merged
JohnVillalovos merged 1 commit intoLibreBooking:developfrom Feb 2, 2026
Merged
fix: Add null check in EnsureNull method#930JohnVillalovos merged 1 commit intoLibreBooking:developfrom
JohnVillalovos merged 1 commit intoLibreBooking:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with the REST API for LDAP-authenticated users by adding a null check in the EnsureNull method to prevent errors when LDAP attributes are null.
Changes:
- Added null check at the beginning of
EnsureNullmethod to handle null values before callingtrim()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
requested changes
Jan 30, 2026
JensWendt
changed the title
JohnVillalovos
force-pushed
the
patch-1
branch
from
2121f9e to
fe39abb
Compare
JohnVillalovos
approved these changes
Feb 2, 2026
Collaborator
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
LGTM
Thanks @JensWendt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes an issue with the REST API for LDAP-authenticated users users