This repository was archived by the owner on Feb 17, 2021. It is now read-only.
Added AutoRotateStackLayout#222
Open
nbadakh wants to merge 1 commit intoLinkedInAttic:masterfrom
nbadakh:rotating_stack_layout
Open
Added AutoRotateStackLayout#222nbadakh wants to merge 1 commit intoLinkedInAttic:masterfrom nbadakh:rotating_stack_layout
nbadakh wants to merge 1 commit intoLinkedInAttic:masterfrom
nbadakh:rotating_stack_layout
Conversation
Contributor
Author
|
- Attached screenshots:
|
|
This would be the first none essential layout that would go into the library. Wouldn't it make more sense to split it in an sub project? |
Contributor
Author
|
Added unit tests |
Contributor
|
@FabianTerhorst you bring up a good point, thank you, we'll consider it. |
- The AutoRotateStackLayout displays its contents along the horizontal axis by default. - If the contents do not fit along the horizontal axis, the AutoRotateStackLayout switchs to displaying them along the vertical axis. - The AutoRotateStackLayout uses to StackLayouts to implement its behavior. - Also added AutoRotateStackViewController to demonstrate the use of AutoRotateStackLayout. - Added unit tests.
Contributor
Author
|
Fixed merge conflicts. |
Contributor
|
@FabianTerhorst We're considering generalizing this component a bit. It would take an array of layout options and at measurement time it would pick the first one that fits. Sounds like a useful primitive for apps that need to support Dynamic Type and languages with long words. What do you think? |
|
Sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- The
AutoRotateStackLayoutdisplays its contents along the horizontal axis by default.- If the contents do not fit along the horizontal axis, the
AutoRotateStackLayoutswitchsto displaying them along the vertical axis.
- The
AutoRotateStackLayoutuses to StackLayouts to implement its behavior.- Also added
AutoRotateStackViewControllerto demonstrate the use ofAutoRotateStackLayout.TODO:
Add tests.