Skip to content

feat(config): add gamepad_driver option - #5653

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/driver
Sep 8, 2026
Merged

feat(config): add gamepad_driver option#5653
ReenigneArcher merged 1 commit into
masterfrom
fix/driver

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description

Adds a gamepad_driver option allowing the user to force a specific gamepad driver on Windows. This should provide clarity around ViGEmBus remaining as a fallback and allows removing the nagging message for Virtual HID Driver for any users who do not want to purchase a license.

Also, shows ViGEmBus as end of life instead of checking GitHub versions (which do not match the driver version).

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 7.11kB (0.21%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 863.62kB 7.11kB (0.83%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/logo-*.js 3.29kB 381.22kB 0.87%
assets/config-*.js 1.24kB 72.69kB 1.74%
assets/index-*.js 2.38kB 48.72kB 5.15% ⚠️
assets/troubleshooting-*.js 195 bytes 13.64kB 1.45%

Files in assets/logo-*.js:

  • ./src_assets/common/assets/web/public/assets/locale/en.json → Total Size: 52.05kB

Files in assets/config-*.js:

  • ./src_assets/common/assets/web/config.html → Total Size: 0 bytes

  • ./src_assets/common/assets/web/configs/tabs/Inputs.vue → Total Size: 15.33kB

Files in assets/index-*.js:

  • ./src_assets/common/assets/web/index.html → Total Size: 0 bytes

Files in assets/troubleshooting-*.js:

  • ./src_assets/common/assets/web/troubleshooting.html → Total Size: 0 bytes

@ReenigneArcher
ReenigneArcher force-pushed the fix/driver branch 3 times, most recently from 6695c52 to 6adc7d4 Compare September 8, 2026 21:56
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Last Updated 2026-09-08 23:25:37 UTC
Source Run CI Run #5391
Commit 4615f1dcee1df54f0dc42997d97ef83a0c29489e

Screenshot Comparison

PR #5653 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.24031% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.51%. Comparing base (c53f97e) to head (4615f1d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/input.cpp 27.45% 20 Missing and 17 partials ⚠️
src/system_tray.cpp 75.00% 2 Missing and 4 partials ⚠️
src/config.cpp 86.20% 3 Missing and 1 partial ⚠️
src/platform/virtualhid_input.cpp 91.66% 2 Missing ⚠️
src/confighttp.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5653      +/-   ##
==========================================
+ Coverage   37.45%   37.51%   +0.06%     
==========================================
  Files         104      104              
  Lines       25922    26016      +94     
  Branches    11433    11482      +49     
==========================================
+ Hits         9709     9761      +52     
- Misses      13398    15228    +1830     
+ Partials     2815     1027    -1788     
Flag Coverage Δ
Archlinux 21.08% <52.77%> (+0.11%) ⬆️
FreeBSD-amd64 23.37% <62.79%> (+0.11%) ⬆️
Homebrew-macos-14 36.51% <73.80%> (+0.15%) ⬆️
Homebrew-macos-15 37.07% <73.80%> (+0.14%) ⬆️
Homebrew-macos-26 37.38% <73.80%> (+0.14%) ⬆️
Homebrew-ubuntu-24.04 25.10% <63.15%> (+0.12%) ⬆️
Linux-AppImage-aarch64 25.66% <63.15%> (+0.12%) ⬆️
Linux-AppImage-x86_64 25.84% <63.15%> (+0.09%) ⬆️
Windows-AMD64 30.18% <45.71%> (+0.07%) ⬆️
Windows-ARM64 25.34% <47.57%> (+0.10%) ⬆️
macOS-arm64 30.73% <71.42%> (+0.04%) ⬆️
macOS-x86_64 31.35% <71.42%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 18.75% <ø> (-6.25%) ⬇️
src/platform/virtualhid_input.h 0.00% <ø> (ø)
src/confighttp.cpp 57.21% <0.00%> (-0.05%) ⬇️
src/platform/virtualhid_input.cpp 97.54% <91.66%> (-0.20%) ⬇️
src/config.cpp 60.86% <86.20%> (+1.04%) ⬆️
src/system_tray.cpp 78.01% <75.00%> (-0.78%) ⬇️
src/platform/windows/input.cpp 17.19% <27.45%> (+0.52%) ⬆️

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53f97e...4615f1d. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit f7e550d into master Sep 8, 2026
78 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/driver branch September 8, 2026 23:27
@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant