Shared folder strategies

[demoran23]

Tangentially related to issue #33, this adds the concept of a shared folder strategy. For SD.Next, it will update the config.json file with the appropriate paths and use them. With that configuration, there should be no need to juggle symlinks in the filesystem.

A similar strategy can be applied to Comfy (cf #33), but it hasn't been implemented here.

[github-actions]

CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA.

[demoran23]

I have read the CLA Document and I hereby sign the CLA

[mohnjiles]

Thank you for the PR! I definitely like the idea behind this, avoiding symlinks while still achieving the shared models directory would be sweet. Just have a couple suggestions & ideas to ponder.

[mohnjiles]

A few things here -

1. In the InstallerViewModel, this is called before the InstalledPackage object has been added to the settings, so this will throw an exception unless they had a previous install of the same package (in which case it'd be using the wrong paths anyway).

2. It is possible to have two different installs of the same package, so using .Single() with the PackageName here could possibly throw. If possible, its best to use the Guid Id when trying to find an InstalledPackage.

3. Since the name property is all that's used from the BasePackage, could the method parameter here just be the name of the package instead of the full thing?

[mohnjiles]

We've been using System.Text.Json for our json parsing, as it has improved quite a bit since the initial release. So that we don't have two different json parsing libraries involved, would it be possible to redo this using System.Text.Json? I believe it should have a similar class to JObject called JsonObject

[mohnjiles]

nit: could you please put curly braces around these statements? According to our style guidelines:

Only omit curly braces from if statements if the statement immediately following is a return.

Thank you!

[mohnjiles]

I wonder if it may be better to implement an abstract method, along the lines of ExecuteSharedFolderStrategy instead - we could inject the ISharedFolders to the implementations of this, so that the packages without custom strategies can just call the original SharedFolders method without the is LinkedFolderSharedFolderStrategy check.

You could still inject the strategies to the classes that need them, we just wouldn't expose the whole strategy object to the callers. You might also need to pass in the directory as a parameter, since the BasePackage doesn't know where it's installed (most of the time).

It might also eliminate the need for LinkedFolderSharedFolderStrategy and avoid the circular reference shenanigans.

I hope that made sense 😅

[gravyboatcaptain]

I'm quite eager to see this implemented. I hope @demoran23 is able to make these changes.

[AkoZ]

As it is about the "shared directory", hey may be also the shared models as checkpoints and clips and loras ..etc.
It was said about easy ways.. BUT i've all my models/checkpoints,Loras, clips yet, then 👍 organised in their own directories.

1. it would be kind and easy to make a third tab about models (the page with civitai and hugging face): there our models own and yet downloaded.
2. BUT there is no fast way to indicate and LET the checkpoints where they are now ?
3. package by package, hey for sure you know which file is the config.txt one to modify and then put the right links to THE checkpoints dirs
4. there are parameters but none about indication to the shared directories of checkpoints ?