Implement scipy.spatial.cKDTree for orthorhombic and no PBC#5193
Implement scipy.spatial.cKDTree for orthorhombic and no PBC#5193Aryaman-Chaudhri wants to merge 8 commits intoMDAnalysis:developfrom
Conversation
|
Thanks for working on this. Before we do any kind of review we need you to address the currently failing tests and also format using |
2247551 to
8abf284
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5193 +/- ##
===========================================
+ Coverage 92.72% 93.75% +1.02%
===========================================
Files 180 180
Lines 22475 22583 +108
Branches 3190 3218 +28
===========================================
+ Hits 20841 21172 +331
+ Misses 1177 937 -240
- Partials 457 474 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @BradyAJohnston , just a quick question , during working on this task , I was wondering why is 'nsgrid' not implemented anywhere , based on documentation it does have a few flaws but seems to be a well optimized and a fast function (also O(N)) atleast on paper. |
|
@BradyAJohnston do you want to take on shepherding this PR? If so, please assign it to you. I am happy to review (once linters pass). |
|
Hi @BradyAJohnston , @orbeckst , I think this is ready for a review . |
Fixes #5114
Changes made in this Pull Request:
-Added benchmarks/benchmarks/neighbors.py proving scipy.spatial.cKDTree is faster than the existing Implemetation.
-Implemented scipy.spatial.cKDTree backend in package/MDAnalysis/lib/pkdtree.py by building a new class.
-Updated testsuite/MDAnalysisTests/lib/test_pkdtree.py to verify both PeriodicKDTree (for API stability) and AugmentedPKDTree.
-Updated package/AUTHORS and package/CHANGELOG to reflect the contribution.
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5193.org.readthedocs.build/en/5193/