chg: update ui-priority in sigma/yara object templates#470
Merged
Conversation
Contributor
Author
|
After applying this PR, the appearance will be as follows. |
fukusuket
changed the title
ui-priority in sigma/yara object templateui-priority in sigma/yara object template
Contributor
Author
|
Before applying this PR, the appearance is as follows. |
fukusuket
changed the title
ui-priority in sigma/yara object templateui-priority in sigma/yara object templates
Member
|
Thank you very much! I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for maintaining misp-galaxy :)
Currently,
YaraandSigmaobjects do not haveui-priorityset by default. This makes other attrubutes harder to spot when viewing events in a collapsed(when clickingCollapse all Attributes) or aggregated view.In this PR, I have set the
ui-priorityof the rule titles to1. This ensures that the rule's titles are displayed at the top, as shown in the screenshot below.I would appreciate your feedback.