Style files and keyword improvements#214
Open
FLAREdirector-mse wants to merge 2 commits into
Open
Conversation
A lot of the contents here are extremely minor edits made to various template style files, with emphasis on getting the alias bars to blend in with the card colors when possible. Certain files also had improper initial states for legend crowns, either hiding them entirely or making them mandatory by default. I adamantly believe this to be a well-intentioned error.
I also took the time to update auto_replace to be up to date with ability words up to Secrets of Strixhaven. Many of them have both a P and an S variant, for ability words whose meaning differs based on whether the card is a Permanent or a Spell. Similarly, I went through keywords_en and swapped out instances of {this_or_that("permanent")} with {this_or_that("type")}.
This branch also contains the data for the M15 Saga Creatures template; I'm not sure why they're not already part of the repository, but that's none of my business.
Lastly, I have included the paper versions of the metallic Universes Beyond frame, the ones that don't have that ugly white splotch in the middle of the type bar. Those older ones that are ostensibly from MTG Arena can still be found in \beyond\default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the contents here are extremely minor edits made to various template style files, with emphasis on getting the alias bars to blend in with the card colors when possible. (The existing gray alias bars can still be accessed with a new boolean in the Style tab.) Certain files also had improper initial states for legend crowns, either hiding them entirely or making them mandatory by default. I adamantly believe this to be a well-intentioned error.
I also took the time to update auto_replace to be up to date with ability words up to Secrets of Strixhaven. Many of them have both a P and an S variant, for ability words whose meaning differs based on whether the card is a Permanent or a Spell. Similarly, I went through keywords_en and swapped out instances of {this_or_that("permanent")} with {this_or_that("type")}.
This branch also contains the data for the M15 Saga Creatures template; I'm not sure why they're not already part of the repository, but that's none of my business.
Lastly, I have included the paper versions of the metallic Universes Beyond frame, the ones that don't have that ugly white splotch in the middle of the type bar. Those older ones that are ostensibly from MTG Arena can still be found in \beyond\default.