Fix connection pool deadlock - #1324
Merged
Merged
Conversation
elprans
approved these changes
Sep 21, 2026
elprans
left a comment
elprans
left a comment
Member
There was a problem hiding this comment.
Calling _release() directly in this case would bypass cleanup of connection-associated resources. Calling _terminate() instead. LGTM otherwise! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the connection pool can be deadlocked if
abort()is called which can cause connection cleanup to be skipped. Refer to the referenced issue for a reproducible exampleCloses #1307