Repository navigation
Conversation
GeorgWa
commented
Dec 22, 2025
GeorgWa
commented
- Add LOG_INTERVAL config parameter (default: 100)
- Add set_log_interval() function following existing config pattern
- Update protein_intensity_estimation.py to use config.LOG_INTERVAL instead of hardcoded value
- Add LOG_INTERVAL config parameter (default: 100) - Add set_log_interval() function following existing config pattern - Update protein_intensity_estimation.py to use config.LOG_INTERVAL instead of hardcoded value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds configurability to the protein processing log interval by introducing a new LOG_INTERVAL configuration parameter. Previously, the logging frequency was hardcoded to every 100 proteins.
Key changes:
- Introduced
LOG_INTERVALconfig parameter with default value of 100 - Added
set_log_interval()function to allow runtime configuration - Updated protein processing logic to use the configurable interval instead of hardcoded value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| directlfq/config.py | Added LOG_INTERVAL configuration variable and set_log_interval() setter function following the existing config pattern |
| directlfq/protein_intensity_estimation.py | Updated logging condition to use config.LOG_INTERVAL instead of hardcoded value 100 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -13,6 +13,12 @@ def set_log_processed_proteins(log_processed_proteins = True): | |||
| global LOG_PROCESSED_PROTEINS | |||
| LOG_PROCESSED_PROTEINS = log_processed_proteins | |||
|
|
|||
There was a problem hiding this comment.
The separator comment uses inconsistent formatting compared to other separators in the file. The separator at line 23 uses the same format, but the separator at line 16 appears after the function definition instead of before the variable declaration like line 23. Consider moving this separator to line 15 to maintain consistency with the existing pattern where separators precede variable declarations.
mschwoer
left a comment
mschwoer
left a comment
There was a problem hiding this comment.
please name 3 reasons why I prefer https://github.com/MannLabs/directlfq/pull/79/changes :-D
|
I used the same global variable mechanism and set method on purpose. If this is what you mean :D |
|
duplicates #79 |
