Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the extension’s built-in update checks when running in newer MarkEdit host versions that ship an extension manager, to avoid redundant self-update behavior.
Changes:
- Added
hasExtensionManager()host capability check based onMarkEdit.runtimeInfo().appVersion. - Forced
updateBehaviorto'never'when the host extension manager is present.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/support/settings.ts | Forces update behavior to “never” on hosts detected to have an extension manager. |
| src/support/host.ts | Introduces version-based host detection for presence of the built-in extension manager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/support/host.ts:21
- The version check assumes
MarkEdit.runtimeInfo()returns an object with a stringappVersion. IfruntimeInfo()returnsundefined/nullorappVersionisn’t a string, callinglocaleComparewill throw and can break initialization. Add a type guard (and trim) before comparing.
// appVersion is always 3 numeric segments, so numeric collation is a safe comparison
const appVersion = MarkEdit.runtimeInfo().appVersion;
return appVersion.localeCompare('1.34.0', undefined, { numeric: true }) >= 0;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.