Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a WebKit rendering quirk where clicking a link can leave the :hover underline state visually “stuck” after focus is stolen, by temporarily suppressing link underlines after a click until the pointer leaves the link.
Changes:
- Add a
.suppress-underlineCSS class to disable link underlines in the rendered markdown preview. - Update the preview pane click handling to apply/remove the suppression class on anchor clicks.
- Regenerate the lite distribution bundle to include the updated behavior and styles.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| styles/main.css | Adds a CSS rule to suppress link underlines when a class is applied. |
| src/view.ts | Adds anchor-click handling to toggle the suppression class and wires it into the preview click listener. |
| dist/lite/markedit-preview.js | Updates the built lite bundle with the new CSS and click-handling logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.