Skip to content

Fix silently failing ListWhere() due to column mismatch #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgabe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix silently failing ListWhere() due to column mismatch #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions structable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ type WhereFunc func(desc Describer, query squirrel.SelectBuilder) (squirrel.Sele
// of each matches the underlying type of the passed-in 'd' Recorder.
func ListWhere(d Recorder, fn WhereFunc) ([]Recorder, error) {
var tn string = d.TableName()
var cols []string = d.Columns(false)
var cols []string = d.Columns(true)
buf := []Recorder{}

// Base query
Expand Down Expand Up @@ -338,7 +338,11 @@ func ListWhere(d Recorder, fn WhereFunc) ([]Recorder, error) {
s := nv.Interface().(Recorder)
s.Init(d.DB(), d.Driver())
dest := s.FieldReferences(true)
rows.Scan(dest...)

if err := rows.Scan(dest...); err != nil {
return buf, err
}

buf = append(buf, s)
}

Expand Down