Fail in last PR regarding the use of json module#225
Merged
Conversation
Pull Request Test Coverage Report for Build 12768577704Details
💛 - Coveralls |
MarcelGeo
requested changes
Dec 12, 2024
Contributor
MarcelGeo
left a comment
MarcelGeo
left a comment
There was a problem hiding this comment.
Fix is ok. We need to update tests to catch these errors for workspace_service method
MarcelGeo
requested changes
Jan 15, 2025
Contributor
There was a problem hiding this comment.
I preffer to cancel this PR and do just few things (or rerevert commits)
- remove just monhtly contributors test manually, do not revert changes (I see there some added print)
- there was also some minor improvements by me and @VitorVieiraZ
- add your testing function for workspace
ValentinBuira
force-pushed
the
fix-typo-parsing
branch
from
7998c7b to
1c0ec53
Compare
MarcelGeo
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typo in my last PR regarding the use of json module
I used
json.loadswith asinstead ofjson.loadthat support de serializing python object and not stringEvery use of workspace_service failed in the plugin because of that