Conversation
MarcelGeo
commented
May 28, 2025
Contributor
|
@alex-cit Can you have a review on this? |
wonder-sk
approved these changes
Jun 12, 2025
Contributor
wonder-sk
left a comment
wonder-sk
left a comment
There was a problem hiding this comment.
Great stuff! Looking forward for more 😉
Pull Request Test Coverage Report for Build 15675428851Details
💛 - Coveralls |
alex-cit
reviewed
Jun 13, 2025
Contributor
alex-cit
left a comment
alex-cit
left a comment
There was a problem hiding this comment.
Great work, guys!
I have left some suggestions related to US/UK spelling (synchronize vs. synchronise, we use UK spelling in the docs), unified use of GeoPackage (vs. geopackage) and use of product names (Mergin Maps mobile app instead of Mergin Maps mobile application).
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
Co-authored-by: Alexandra Bucha Rasova <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce examples using python notebooks
2 scenarios are ready to check if there is everything fine